[FIX] Guard .first() queries against None to prevent AttributeError#1070
Open
DhanushVarma-2 wants to merge 2 commits intoCCExtractor:masterfrom
Open
[FIX] Guard .first() queries against None to prevent AttributeError#1070DhanushVarma-2 wants to merge 2 commits intoCCExtractor:masterfrom
DhanushVarma-2 wants to merge 2 commits intoCCExtractor:masterfrom
Conversation
DhanushVarma-2
requested review from
canihavesomecoffee and
thealphadollar
as code owners
DhanushVarma-2
force-pushed
the
fix/none-dereference-on-empty-queries
branch
3 times, most recently
from
351ecd3 to
b7db2b8
Compare
Three queries called .first().value or .first().commit without checking for None. On a fresh install or empty database, these crash with AttributeError. Fixed in mod_ci/controllers.py, mod_home/controllers.py, and mod_sample/controllers.py.
DhanushVarma-2
force-pushed
the
fix/none-dereference-on-empty-queries
branch
from
b7db2b8 to
c88f2a1
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three queries called .first().value or .first().commit without checking
for None. On a fresh install or empty database, these crash with
AttributeError.
Fixed:
Downstream query for last_commit skipped when commit_hash is None
to avoid WHERE commit IS NULL.
Template receives None which Jinja2 renders gracefully.
Downstream Test queries skipped when values are None.